Skip to content

Competitive Coding 2#1165

Open
shinjaneegupta wants to merge 1 commit intosuper30admin:masterfrom
shinjaneegupta:master
Open

Competitive Coding 2#1165
shinjaneegupta wants to merge 1 commit intosuper30admin:masterfrom
shinjaneegupta:master

Conversation

@shinjaneegupta
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The Two Sum solution is correct and efficient, with optimal time and space complexity.
  • The code is well-structured and readable, with clear variable names and comments.
  • The approach is well-explained in the comments.

Areas for Improvement:

  • The Knapsack solution is not relevant to the Two Sum problem and should not be included in the submission for this problem. Ensure that you only submit code that is directly related to the problem at hand.
  • In the Two Sum solution, the variable name "map" is a built-in function in Python. It is better to avoid using built-in names as variable names to prevent confusion and potential errors. Consider renaming it to something like "num_dict" or "seen".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants